OpenModelica / BioChem

BioChem is a package for biochemical modeling and simulation with Modelica
7 stars 12 forks source link

Inconsistent declarations of some interfaces (partial / without partial) #10

Closed AtiyahElsheikh closed 4 years ago

AtiyahElsheikh commented 4 years ago

Some abstract models within Interfaces/Reactions package should be declared as "partial", for instance:

While the above models have more variables than equations, some models are consistent in this regard such as:

In the sense that these models are employed as interfaces and not as stand-alone components, to achieve consistency, I think all models in this subpackage should be also made abstract.

p.s. I will usually keep an issue open at least for one month, in case any one would like to comment!