OpenModelica / OMMatlab

Matlab scripting OpenModelica interface
12 stars 4 forks source link

More linearization bugs #12

Closed crazy734 closed 3 years ago

crazy734 commented 3 years ago

I have found more linearization bugs in this code and fixed them. They have given me multiple errors during usage as they are and therefore, I've taken time to verify the changes as well. So it would be great if you could merge the code.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

arun3688 commented 3 years ago

@crazy734 can you sign the CLA

crazy734 commented 3 years ago

I have already signed @arun3688. However, the status is still pending so I pasted the info from there over here.

adrpo commented 3 years ago

@crazy734 please force push a change to the code? That will force the CLA to rerun. Also, make sure you sing with the same email address that you have in the github account.

crazy734 commented 3 years ago

Hello @adrpo. Thanks for the suggestion. I did. My name is Guru Charan Das but my username is crazy734. So this issue still persists for that name. I have tried resolving it, however, there seems to be no solution. Is merging the code possible now then?

adrpo commented 3 years ago

@crazy734 I get it now, you used a different user name for the first commit. You will need to change the author of the first commit or close this PR and make a new one with the same changes but use your github user for the first commit.

sjoelund commented 3 years ago

@crazy734 I get it now, you used a different user name for the first commit. You will need to change the author of the first commit or close this PR and make a new one with the same changes but use your github user for the first commit.

No, it's enough to associate the Philips email address with his github account: https://github.com/settings/emails

crazy734 commented 3 years ago

@sjoelund I have associated. It still does not show as verified.

sjoelund commented 3 years ago

If you press the recheck button, it updates :)

crazy734 commented 3 years ago

@sjoelund thanks bro!

crazy734 commented 3 years ago

Hey @arun3688, could you please review the code and merge it to close the pull request?