OpenModelica / OpenModelicaLibraryTesting

Test script for OMCompiler+OpenModelicaLibraries
Other
9 stars 14 forks source link

MSL and PowerSystems examples are reported with errors even though they work #10

Open rfranke opened 3 years ago

rfranke commented 3 years ago

The nightly tests report simulation errors for these two examples:

Modelica.Electrical.Spice3.Examples.Oscillator
Modelica.Electrical.Spice3.Examples.Spice3BenchmarkDifferentialPair

See https://libraries.openmodelica.org/branches/master/Modelica_trunk_cpp/Modelica_trunk_cpp.html Screenshot from 2021-08-24 15-18-58

The examples appear to simulate though and Oscillator should not take that long. The examples do also work with MSL 3.2.3.

Edit: the two examples do also fail for Modelica_trunk.

What is wrong?

casella commented 3 years ago

@rfranke is this a regression or was it always like that?

rfranke commented 3 years ago

I assume that there is something wrong with the test setup. Just discovered that these two examples are working in OMEdit and are also reported as success for daily MSL 3.2.3 tests. One of them, Modelica.Electrical.Spice3.Examples.Oscillator, is also reported as success for daily MSL 4.0.0 tests.

casella commented 3 years ago

@sjoelund would you mind having a look?

rfranke commented 3 years ago

Here is one more example that is reported as simulation error for PowerSystems_cpp even though it works :

PowerSystems.Examples.AC3ph.Generation.Islanding
rfranke commented 3 years ago

Yet another example: Modelica.Electrical.Analog.Examples.AmplifierWithOpAmpDetailed verifies since yesterday, but is still reported with the same wrong results as before, see https://github.com/OpenModelica/OpenModelica/commit/5ae02bbd5fdbbd07418c56862207cffc1f7846ce#diff-eb8d9f8a258b1410ea4631cd9647a54ee1e62ee6ccd11f60b11d840567024328

From current library tests: image

In OMEdit: image