search

OpenModelica / modelica-language-server

A VS Code language server extension for Modelica.
Other
5 stars 2 forks source link

Add support for multiple files #24

Closed ehedbor closed 4 months ago

ehedbor commented 4 months ago

This branch was based off the prettier branch and was created before the PR (#23) was accepted. It seems that Git thinks the prettier commits in main are different from the ones in this branch, so its counting all the changes twice. Now Git is asking me to resolve changes that are supposed to be in the past and I'm not entirely sure how to fix this. We definitely did not change 30 files in this pull request!

PaddiM8 commented 4 months ago

I rebased it to change the parent commit. Seems to have worked.

PaddiM8 commented 4 months ago

@AnHeuermann

AnHeuermann commented 4 months ago

The end to end test is failing for me (and the CI). When calling getDeclarationsForUri for client/testFixture/MyLibrary.mo the tree is not yet created. I guess in addition to automatically exploring files from the workspace directory you need to analyze opened files from outside the workspace directory. Maybe an additional call to addDocument is needed?

PaddiM8 commented 4 months ago

Yeah that was the problem indeed. It should now add documents that don't belong to a library in the workspace.

PaddiM8 commented 4 months ago

Could you re-run the tests?

AnHeuermann commented 4 months ago

I forgot to enable the contributor license agreement for this repository. I enabled it just now, and it tells that everybody did sign the CLA. @ehedbor and @PaddiM8 can you confirm or is it just broken?

AnHeuermann commented 4 months ago

Did a quick double check and everybody signed the CLA. Perfect.