OpenMods / OpenBlocks

Random collection of blocks
Other
297 stars 149 forks source link

1.2.7 Radio broken? #366

Closed Sir-Will closed 10 years ago

Sir-Will commented 10 years ago

hey, somehow I get the radio not to work in the version 1.2.7. It works for me in 1.2.5 with the same stations. This are my stations:

    # List any radio stations you want
    S:radioStations <
        "http://69.4.234.186:9140/;Default;Blue"
        "http://23.227.171.50:8052;Radio Paradise;Orange"
        "http://69.46.75.101:80;idobi Radio (idobi.com);Blue"
        "http://192.184.9.79:8006;CINEMIX;Blue"
        "http://radiorivendell.de:80/;Radio Rivendell;Blue"
        "http://205.164.62.15:10052;1.fm Love Classics;Blue"
        "http://theradio.cc:8000/trcc-stream.mp3;TheRadioCC;Red"
        "http://streaming202.radionomy.com:80/abacusfm-vintage-jazz;Vintage Jazz;Red"
        "http://s1.stream-experts.net:8032/;Nature sounds;Red"
        "http://91.121.166.38:7016/;British Comedy;Red"
        "http://50.7.173.162:8010;Audiophile Baroque;Red"
        "http://streaming.radionomy.com/adam-fm-radio;Adam FM;Orange"
     >

And I get for every station this error:

2014-04-06 03:15:26 [Warning] [OpenMods] openblocks.client.radio.RadioManager.error(RadioManager.java:82): Unknown MIME type audio/mpeg in stream http://streaming.radionomy.com/adam-fm-radio

Did I something wrong or is it broken in 1.2.7?

boq commented 10 years ago

Answer is in changelog and directly on http://openmods.info/: look under NotEnoughCodecs

HaoSs07 commented 10 years ago

we still live in the " manual add mod for x to work " world ? why not just add codec to openblocks mod. and make a button in options to turn radion on/off ? i dislike this change

mikeemoo commented 10 years ago

My ability to care is limited.

HaoSs07 commented 10 years ago

well here goes the best feature from the mod out the window.

boq commented 10 years ago

It's not about "radio disable/enable switch", it's "we don't want to maintain, compile every time and distribute extra 50k lines of code, which also is under different license". If you think it's too much hassle to download single client-side mod, well, no radio for you.

jvantuyl commented 10 years ago

Would you be willing to be extra sure that people that bundle your mods know this? FTB doesn't bundle it now, so this block is effectively useless for a large number of users.

Is it your fault? Not exactly. Could messaging improve the usability for many users? Yes.