search

OpenMods / OpenBlocks

Random collection of blocks
Other
298 stars 149 forks source link

Right clicking liquid XP Tank fails in edge cases #439

Open mmseng opened 10 years ago

mmseng commented 10 years ago

I was playing Agrarian Skies v3.1.1 (OpenBlocks v1.2.8) and came across a situation where I could not right click on an OpenBlocks tank containing liquid XP. The right-clicking player animation wouldn't happen and no XP would be taken from the tank. As it turned out it was a very odd circumstance where my XP bar was completely full. As soon as I gained a couple of XP points to bring my XP bar into the low end of the next level I was able to right click the tank successfully.

I've tested this with the latest OpenBlocks v1.2.9 and OpenModsLib v0.5.1 in vanilla Minecraft (using Forge 1.6.4-9.11.1.965) and was able to replicate it.

In the above environment, follow these steps to replicate:

I'm not actually sure if this is an OpenMods bug or not. According to my math, using the Minecraft Wiki page on experience, 22070 xp SHOULD already give you 100 levels. I'm wondering if it's not Minecraft itself reporting the level calculation incorrectly, which is confusing OpenBlocks. Either way that's above my head and I figured I'd report it.

P.S. for the record, the issue in my Agrarian Skies world happened on a much lower level. I don't recall exactly but I'm sure it was less than 10 or 20.

boq commented 10 years ago

According to Minecraft, 22070 is 99 levels and 99.999845% of bar, while 22071 is 100 levels and 0.18100711% of bar. Looks like OpenBlocks is incorrectly reporting 22070 as threshold for level 100.

Minecraft value is correct one (since it's one that everything uses), while we are using shortened equation, which is subject to rounding errors.

Thanks for report (:+1: for testing in most recent version, this is actually very rare). But this looks like low priority bug, so no 1.6 fix (I will play with it in 1.7)

mmseng commented 10 years ago

Glad to help. Now that I know what's going on it's not an issue, just have to go kill a cow or something before clicking (if it ever even happens again), but damned if I wasn't really bummed when I thought I had no way to get my XP back in Agrarian Skies XD (XP shower and bottler, etc. are disabled for this pack, not really sure why).