OpenMods / OpenBlocks

Random collection of blocks
Other
297 stars 150 forks source link

[Suggestion] Grave Expiration #591

Open ghost opened 9 years ago

ghost commented 9 years ago

Would it be possible to have graves disappear after X seconds (say, 300, 5 minutes by default). After which, the items will be released as they would a regular death.

teamvista commented 9 years ago

The grave was designed to be similar to a death chest, in which its contents were meant to be saved until someone digs it up. As such, it provides a safe(r) way to retrieve the goods as the items would despawn otherwise. This suggestion would go against the general purpose of the block and the recent commit 3a5cf4b3.

What reasoning do you have in this suggestion? If you don't want graves, you can disable them simply by setting its id to 0, and items will fall to the ground as normal.

boq commented 9 years ago

I somehow understand this one. When you have lots of players (especially on open servers), spawn areas (and other protected regions) might get messy. I recently fixed that (39b3e231dc22a9eaef569e6f65b642920f00a8e1, though I'm not sure if it works with plugins), but graves expiration may still be option for larger servers (since it's still reduces entity count and allows extending drops below vanilla 5 minutes)

Though if I'm adding this one, it's never going to enabled by default. It will be config option, and it will be up to server admins to deal with all that grief and discontent it causes when enabled.

ghost commented 9 years ago

Well, the main issue is graves getting stuck in someone elses land, but if your checker is in a stable enough build I can try that out. What happens if a grave can't be placed?

boq commented 9 years ago

Probably nothing production-ready. And I'm generally against using snapshots on larger scale.

Twisted-Code commented 9 years ago

I like the idea of grave expiration, but think it should be disabled by default. A longer timeframe would probably be appropriate, as well. Perhaps 10 minutes and then it automatically dumps onto the ground but only has one minute remaining on the entity deletion timer. Alternatively, you might try ensuring that the owner of the grave is able to access it? I would either use a fake player or I would work around the typical block interaction permissions and just check that it's the grave owner before allowing access.