OpenMods / OpenPeripheral-Addons

An addon for OpenPeripheral, adding physical blocks and items to the game
MIT License
11 stars 10 forks source link

glasses chat command doesn't work #65

Closed JomerDev closed 9 years ago

JomerDev commented 9 years ago

I have a glasses terminal attached to a computer via the network cables. Every other event is recieved fine, I recieve the glasses_attach and glasses_detach events. But the chat command is never recieved

boq commented 9 years ago

Glasses chat events are triggered by $$ (since earliest version). Though I might remove that limitation.

JomerDev commented 9 years ago

I know that they are triggered by $$. It still doesn't work. The chatbox commands from MoarPeripherals work fine (with ##), but the glasses commands just don't work

boq commented 9 years ago

Then I'm unable to reproduce your issue. Anything interesting in logs?

JomerDev commented 9 years ago

i found this: [Server thread/INFO] [MoarPeripherals/MoarPeripherals]: [MoarP]: Detected OpenPeripheral-Addons installed. Registering the terminal glasses command as a ChatBox command so it is ignored by ChatBoxes. I'm guessing MoarPeripherals is overwriting the command. I've already opened an Issue there and am sorry to have coused this much trouble ;)

boq commented 9 years ago

Hmm, I don't see how code on MoarPeripheral side can cause this...

EDIT: Looks like it was fixed in theoriginalbit/MoarPeripherals#26, but somehow most recently released version (MoarPeripherals-1.7.10-1.7-1.53.jar) still contains old code

boq commented 9 years ago

NOTE: just changed glasses to listen to ALL chat messages (but ones prefixed by $$ are still not visible in chat).

theoriginalbit commented 9 years ago

EDIT: Looks like it was fixed in theoriginalbit/MoarPeripherals#26, but somehow most recently released version (MoarPeripherals-1.7.10-1.7-1.53.jar) still contains old code

Yeah it seems I didn't push out a few major bug fixes a few months ago...