AdapterBeeHousing enhancement

OpenMods / OpenPeripheral-Integration

Extra OP adapters

MIT License

9 stars 9 forks source link

AdapterBeeHousing enhancement #27

Closed secondfry closed 8 years ago

secondfry commented 8 years ago

Fixes #26 – now it does report all species instead of all mutations. Adds argument for getBeeBreedingData() to honor IMutation.isSecret() status. Iterates over IAllele for IAlleleSpecies for name of result of mutation.

Vexatos commented 8 years ago

Mind that it should only list species that are not marked as secret.

secondfry commented 8 years ago

@Vexatos, it is not current behavior tho, should it really behave this way? [UPD] For example default setting in NEI Addons 1.12.14.40 is 'add all bees to NEI search'.

Vexatos commented 8 years ago

It is actually not. Secret species aren't shown by default, neither are secret mutations.

secondfry commented 8 years ago

@Vexatos, judging by code of NEI Addons and testing in-game showSecret only hides the mutation while addBees still adds it to listing. Proof

Vexatos commented 8 years ago

Interesting.

I still think they should not be shown. They are secret for a reason.

secondfry commented 8 years ago

@Vexatos, I dig some more. IAlleleSpecies.isSecret() equals true for all species besides Forestry starters and doesn't relate to actual secret species. That's why addBees in NEI Addons adds all bees. There is IMutation.isSecret() tho which relates to showSecret in NEI Addons directly. I will implement argument for AdapterBeeHousing.getBeeBreedingData() in silimar way then.

boq commented 8 years ago

Thank you for submitting your solution, but I've decided to close issue via 2436fae666489670fac588e98a9555ce686547c5. This PR had few problems:

instead of missing parent species it ignored childs - so list would contains primals, but would omit bees without any mutations. Also, weird bees without any mutations (if any)
.contains(...) on List<Map<String, String>> is terribly inefficient
if API says something should be hidden, it should be hidden. But as always, I give admin option to restore old behaviour via config flag

secondfry commented 8 years ago

@boq, well, whatever, I was thinking ArrayList is actually a HashMap, rookie mistake. Thanks for solving a dispute.