OpenMods / OpenPeripheral

https://openmods.info
MIT License
67 stars 25 forks source link

Aspectalyzer methods overhaul #184

Closed Cypher121 closed 10 years ago

Cypher121 commented 10 years ago

OpenPeripheral counts Aspectalyzer (Thaumic Tinkerer) as inventory and removes all it's methods, including getAspects() which is the only purpose for that block. Added it into the blacklist, but that's still wrong.

boq commented 10 years ago
Cypher121 commented 10 years ago

Yes, found blacklist in second config file. Version is 0.4.1 for CC 1.6.3. Switched from 0.3.3, where everything worked fine.

boq commented 10 years ago

It worked in CC 1.5x, but mechanism of deciding which peripheral is used changed in 1.6. I will try to contact TT authors, there are some options to blacklist directly in code.

Cypher121 commented 10 years ago

OK, thanks.

Cypher121 commented 10 years ago

Also, if I just blacklist "vazkii.tinkerer.common.block.tile.TileAspectAnalyzer", game stops seeing that block as peripheral at all. Waiting for fix.

boq commented 10 years ago

Can't find any bug in code. We are correctly ignoring blacklisted TEs.

Check if it works without OpenPeripheral. If no, make sure you have correct TT version for CC 1.6.

Cypher121 commented 10 years ago

I have build 140, which is the last build for MC 1.6.4. If it doesn't support CC 1.6, then no other version does.

theoriginalbit commented 10 years ago

@boq the Ignore annotation is how we ignore them in code correct?

boq commented 10 years ago

Either that or any member named OPENPERIPHERAL_IGNORE. https://github.com/OpenMods/OpenPeripheral/blob/master/src/main/java/openperipheral/adapter/PeripheralHandlers.java#L112

vScourge commented 9 years ago

Did this get fixed? I'm still seeing no aspect methods on Aspectalyzers using CC 1.63, OpenPeripherals 0.4.1 snapshot 139, TT 2.3-140. I believe those are all the latest for 1.6.4.