search

OpenMods / OpenPeripheral

https://openmods.info
MIT License
67 stars 25 forks source link

markDirty not called when moving stuff out of inventory #214

Closed mcalpha closed 9 years ago

mcalpha commented 9 years ago

I've made a system where a ComputerCraft turtle pulls items from an interface's exported item slots into itself using the OpenPeripheral integration. (Method name is pushItem, which is supposed to push an item from the inventory to another adjacent inventory.) The slot is accessed correctly and the item(s) are transferred, but the interface seems to not "notice" this and doesn't refill the export slot. When I open the interface's GUI and click into the export slot, it is filled again.

At the AE tracker (https://github.com/AppliedEnergistics/Applied-Energistics-2/issues/551) people suggested this is because OpenPeripheral doesn't call markDirty() on the inventory when moving stuff out...

mcalpha commented 9 years ago

Versions: OpenModsLib-1.7.10-0.6-snapshot-268.jar OpenPeripheralAddons-1.7.10-0.2.0-snapshot-138.jar OpenPeripheralCore-1.7.10-0.5.0-snapshot-171.jar OpenPeripheralIntegration-1.7.10-0.1.0-snapshot-16.jar

boq commented 9 years ago

I probably fixed that in OpenModsLib and OpenPeripheralIntegration. Please confirm (update all Open* mods).