search

OpenMods / OpenPeripheral

https://openmods.info
MIT License
67 stars 25 forks source link

Support the OpenComputer. #94

Closed ghost closed 10 years ago

ghost commented 10 years ago

http://www.minecraftforum.net/topic/2201440-opencomputers/

OpenComputer is Alternative ComputerCraft, it have presist option for chunk loading/unloading don't make reboot the computer. (and it use Lua!)

However, it have own api, it means when decided support the opencomputer, that will very hard work likely write new mod.

That is API, https://github.com/MightyPirates/OpenComputers/tree/master/li/cil/oc/api

theoriginalbit commented 10 years ago

I don't see anything useful to adding this. Maybe you can, if so please share.

However, it have own api, it means when decided support the opencomputer, that will very hard work likely write new mod.

We don't have any problems adding support for mods that don't have APIs, its just as easy when they don't have APIs (I think that's what you were saying, your English was a little hard to understand)

ghost commented 10 years ago

That is must be hard, because

A. I'm not saying about the support OpenComputer's TileEntity as Peripheral. (sorry, i missed it) B. OpenComputer have Component (= CC's Peripheral), I (and other user?) want use OpenPeripheral's thing as Component.

theoriginalbit commented 10 years ago

The components are either OpenComputer specific, meaning that there is no need to make them a peripheral, or they should already be supported, for example you should be able to read the power levels of the battery. I don't see anything else that you'd really want or need.

fnuecke commented 10 years ago

Hi. Not sure if this was a language barrier thing and a simple misunderstanding, so I'd like to clarify before we put more time into it. I think what EcmaXp meant was to make it so that OP also serves as a driver layer for OpenComputers, in addition to ComputerCraft.

We (i.e. LordJoda and me) were thinking of having a look into that. From the cursory glance I had, I'm thinking it'd involve adding a driver registration next to the ones for CC and some wrapper stuff. The only actual modification to the existing sources would probably be the callbacks, depending on how the computer/Lua context from CC is used (since OC can't/won't emulate that). Maybe something along the lines of an interface that allows getting the "real" context. And for methods that require the CC context, those would just wouldn't work in OC (unless it's easy to work around). The problem with that is: there are obviously a lot of callbacks, so that'd be a ton of files touched.

Now before we sink some time into this, I just wanted to ask if you'd even consider merging such a possibly intrusive pull request? If it has to it could become a fork, if you don't mind, but I'd like to avoid that unless it proves necessary, since it'd be easier to maintain if it weren't.

Anyway, please let us know what you think :-)