OpenNBS / OpenNoteBlockStudio

An open-source Minecraft music maker.
https://noteblock.studio
MIT License
765 stars 51 forks source link

Support for Noteblocks++ #303

Open KP2048 opened 2 years ago

KP2048 commented 2 years ago

I recently made a mod for 1.18 forge/fabric That extends the vanilla noteblock range from 2 octaves to 6. Instead of just adding sound files and playing them like you do in your datapack, noteblocks++ modifies the noteblock code to support the same range. all you would need to do to set a noteblock to use the vanilla, upper, or lower octave sets is to set a blockstate property called “octave” to “mid”, “high”, or “low” respectively.

Additional context https://www.curseforge.com/minecraft/mc-mods/noteblocks

Bentroen commented 2 years ago

Hello, and thanks for opening the issue!

Unfortunately, support for modded versions of Minecraft isn't planned at the moment, at least for the official program. That's mainly because of the difficulty in maintaining all the different export options (for different mods/versions/MC versions) alongside supporting vanilla Minecraft.

Third-party tools may be developed to expand those possibilities, and we do plan to allow OpenNBS to be extended with plugins in the future, so it's even easier to integrate these tools into your workflow. For now, at least, your best option would be to code something based on pigstep, an NBS data pack generator which uses pynbs to read its files.

Also, there's one additional issue which is that schematic export isn't updated to support 1.13+ yet (check #29 for more details). That's another limitation that would prevent the integration with the mod in the way you described, since block states aren't implemented in the code at all!

Despite the not-so-positive answer, thank you so much for expanding the NBS ecosystem! Your mod is awesome and I hope to see it being used in many creations going forward :)

KP2048 commented 2 years ago

It uses architectury so I can backport it all the way to 1.16 but not lower

KP2048 commented 2 years ago

Would the plug-in system require game maker studio 2? Or would it just be like .dll/.so? I don’t have gms2 so if I were to make a plug-in for this I would need to know if I could use my existing ide