OpenNBS / OpenNoteBlockStudio

An open-source Minecraft music maker.
https://opennbs.org/
MIT License
730 stars 50 forks source link

Add ImGui Dialogs #385

Closed time-killer-games closed 1 year ago

time-killer-games commented 1 year ago

OpenNBS-Light

OpenNBS-Dark

Download pre-built binaries for Windows, macOS, and Linux here: [GITHUB RELEASE]

time-killer-games commented 1 year ago

the non-file dialogs (show_message(), show_question(), and show_question_ext()) flicker their graphics context back in forth from drawing their content to drawing all solid black. This has now been fixed with my libfiledialogs extension but i still need to commit those fixes to this repository. Please be patient and don't merge this until i have done so.

charlie-sans commented 1 year ago

hey time! would you like me to build them for windows?.

time-killer-games commented 1 year ago

hey time! would you like me to build them for windows?.

Sure! Thank you!

Source code here:

https://github.com/time-killer-games/libfiledialogs

Requires Visual Studio 2019 or later.

charlie-sans commented 1 year ago

i have visual studio 2022. could you also link to instructions on how to build using visual studio. as i main vscode and i have never once built for windows

time-killer-games commented 1 year ago

@charlie-sans It's not the dll I need, actually, it's the exe it builds I need, for clarification. 1) File -> Open. Select *.sln File. It is in libfiledialogs/filedialogs/filedialogs.sln. 2) Select "Debug" Dropdown Box and change it to Release, (unless it's already set to Release). 3) Select "x86" Dropdown Box and change it to x64, (unless it's already set to x64). 4) Build solution. The file wll be in libfiledialogs/filedialogs/x64/Release.

Visual Studio 2022 should work btw.

time-killer-games commented 1 year ago

@Bentroen @chenxi050402 this one should be ready for review, and if you find any issues i still haven't noticed, please let me know!

charlie-sans commented 1 year ago

The file dialogues for Windows are also built by the help of me. I thank you for letting me be of assistance.

On Sat, 25 Mar 2023, 7:14 am Samuel Venable, @.***> wrote:

@Bentroen https://github.com/Bentroen @chenxi050402 https://github.com/chenxi050402 this one should be ready for review, and if you find any issues i still haven't noticed, please let me know!

— Reply to this email directly, view it on GitHub https://github.com/OpenNBS/OpenNoteBlockStudio/pull/385#issuecomment-1483356149, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4EUQ4MBDRK5VCVTJ4RIUK3W5X6CPANCNFSM6AAAAAAV6B6VAU . You are receiving this because you were mentioned.Message ID: @.***>