search

OpenNBS / OpenNoteBlockStudio

An open-source Minecraft music maker.
https://noteblock.studio
MIT License
746 stars 51 forks source link

Memoryerror with 384,000 sampling rate #394

Open pickingname opened 1 year ago

pickingname commented 1 year ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. click file
  2. click export as audio track
  3. change the sampling rate to 384,000
  4. wait untill the error pops ups

Expected behavior exports with 384,000 sampling rate

Screenshots image

Additional context i dont know is it because it has been used all of my ram windows 10, 24gb ram!!

Also i imported the song from midi

Bentroen commented 1 year ago

Hi! Could you please check (and if possible, attach a screenshot of) your RAM usage in the Task Manager right before the error appears? Since NBS is a 32-bit executable, I'd like to know if it's related to the 32-bit memory address limit (4 GB max) or if something else is causing the issue.

pickingname commented 1 year ago

image

Probably around at the spike

also the thing that i discovered is that when you got the memoryerror error dialog box, the app that you are focusing will freeze, and the logo of the error box will be that app logo. it looks like the app that is focused is issuing the error.

Example: I got the memoryerror when i am focusing on firefox, the firefox will hang or freeze and the information box logo will be firefox

Bentroen commented 1 year ago

Sorry, I meant the memory usage of NBS (which you can see in the 'Processes' tab), not your entire system's RAM usage :) Could you check whether it gets close to 4 GB as the error is about to occur? (Looking at the graph it doesn't seem like it, I'd just like to eliminate or confirm that this is causing the error).

it looks like the app that is focused is issuing the error.

That's a different issue we can't do much about, as the emission of popups is handled by GameMaker (the engine that NBS developed on) and we've got little control over it.

pickingname commented 1 year ago

Sure, i recorded the video of it, the error pops up on the top right of the screen

https://github.com/OpenNBS/OpenNoteBlockStudio/assets/115550149/65da98cf-dba9-42ab-9239-4e1daca3eaf4

1,737.8 MB when it is occured

Bentroen commented 1 year ago

Yeah, the memory usage spikes, but it doesn't seem to get close to 4 GB, so the problem must be caused by something else.

Would you mind attaching the affected song to this issue so it's easier to reproduce? (You can also send it privately to me on Discord: Bentroen#7626)