OpenNBS / OpenNoteBlockStudio

An open-source Minecraft music maker.
https://opennbs.org/
MIT License
728 stars 50 forks source link

Playback looping doesn't respect "Times to loop" property #406

Open IoeCmcomc opened 1 year ago

IoeCmcomc commented 1 year ago

Describe the bug When playing a song with looping is enabled in the editor, the editor always loop infinite times. The "Times to loop" song property is simply ignored, while the "Loop start tick" property is taken into account.

To Reproduce Steps to reproduce the behavior:

  1. Open any song
  2. Make sure looping is enabled in the toolbar
  3. Go to Settings -> Song properties...
  4. Enable the song's looping and set its max loop count to a non-zero number
  5. Click OK
  6. Save the file
  7. Play the song
  8. See the song is looped infinitely

Expected behavior The editor should loop the number of times specified in the song properties, with the exception of 0 (infinite).

Screenshots image The highlighted property is ignored by the program.

Additional context Version: 3.10.0 OS: Windows 11 64-bit