OpenNBS / OpenNoteBlockStudio

An open-source Minecraft music maker.
https://opennbs.org/
MIT License
728 stars 50 forks source link

Program version on windows is undefined. #410

Open maitreyorene opened 1 year ago

maitreyorene commented 1 year ago

Describe the bug The program version is not defined the windows registry. Therefore the winget utility fails to find the software version and still detects an available update. To Reproduce Steps to reproduce the behavior:

  1. Go to 'shell'
  2. Execute command 'winget list --id OpenNoteBlockStudio.MinecraftNoteBlockStudio.'
  3. See version unknown

Expected behavior Please define a version for your executable. And thank you for reading this issue.

Screenshots accually

What it should give fixed

maitreyorene commented 1 year ago

EDIT: by default missing regedit DisplayVersion key in "HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Minecraft Note Block Studio" Fixed regedit fixed

maitreyorene commented 1 year ago

powershell script to fix it

$value = (Get-Command "$env:USERPROFILE\Minecraft Note Block Studio\Minecraft Note Block Studio.exe").FileVersionInfo.FileVersion
$update = ((Get-ItemProperty -Path "Registry::HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Minecraft Note Block Studio\").DisplayVersion -ne $value)
if ($update){
    Set-ItemProperty -Path "Registry::HKEY_CURRENT_USER\SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\Minecraft Note Block Studio\" -Name DisplayVersion -Value $value
}
sandyysandy commented 1 year ago

hey i ran the installer exe file through virus total and 3 anti-virus went of about a trojan virus

Screenshot 2023-06-21 154519

and i surched it up and google said this: A Trojan Horse Virus is a type of malware that downloads onto a computer disguised as a legitimate program. The delivery method typically sees an attacker use social engineering to hide malicious code within legitimate software to try and gain users' system access with their software.

Bentroen commented 1 year ago

Hi @sandyysandy, that's a false positive. NBS is used daily by hundreds of users and all the code that it's running is available for inspection here on GitHub, so rest assured it won't harm your computer. Also, please open a different issue if you have any further inquiries, as each issue should only handle a single question. :)