OpenNBS / OpenNoteBlockStudio

An open-source Minecraft music maker.
https://noteblock.studio
MIT License
764 stars 51 forks source link

Looping as a datapack occurs directly after the last note is played #455

Open scutoel opened 6 months ago

scutoel commented 6 months ago

Describe the bug When exporting as a datapack it will start the loop immediately after the last note is played and doesn't have the correct buffer.

To Reproduce Steps to reproduce the behavior:

  1. Create simple looping song. Create a silent note to loop more closely image
  2. Export as datapack
  3. Play the datapack in game. In this example 2 ticks will be skipped.
  4. A work around for this to have the last set the nbs scoreboard to -(speed*2), -80 for 10ticks per second. A better solution would be to have the buffer on the last note and not the beginning of the first note. But its more work to do manually.

Expected behavior Notes should not occur 1tick after the last is played when looping. It should keep the same rhythm and have the blank space after the last note

Bentroen commented 6 months ago

Hi! Thanks for reporting the issue. Do you mind attaching the data pack you used so we can replicate this more easily?

scutoel commented 6 months ago

test.zip test_double.zip It is easier to hear with the double