OpenNBS / OpenNoteBlockStudio

An open-source Minecraft music maker.
https://noteblock.studio
MIT License
764 stars 51 forks source link

Adding new layer above solo layers causes the buttons to break #463

Open BedrRedstone opened 3 months ago

BedrRedstone commented 3 months ago

Adding a new layer above a solo layer moves the toggled buttons to the layer below and deactivates the button toggle on the old one

Steps to reproduce the behavior:

  1. Make a new song
  2. Click on "Solo this layer"
  3. Add a new layer above the soloed layer
  4. Toggle breaks

Expected behavior The layers that were soloed should keep the same toggle, even when a new layer is added

image

Bentroen commented 3 months ago

Thanks for reporting the issue! I believe this should be an easy fix - will have a look at it for 3.11.

Also, I updated your reproduction steps a little to clarify that you should lock two layers in order for it to work.

BedrRedstone commented 3 months ago

Thanks for reporting the issue! I believe this should be an easy fix - will have a look at it for 3.11.

Also, I updated your reproduction steps a little to clarify that you should lock two layers in order for it to work.

Actually, this doesnt need two locked layers image

Bentroen commented 3 months ago

Thanks for reporting the issue! I believe this should be an easy fix - will have a look at it for 3.11.

Also, I updated your reproduction steps a little to clarify that you should lock two layers in order for it to work.

Actually, this doesnt need two locked layers image

Ah, my bad! The screenshot made me think otherwise. 😅