search

OpenNMT / OpenNMT-py

Open Source Neural Machine Translation and (Large) Language Models in PyTorch
https://opennmt.net/
MIT License
6.67k stars 2.24k forks source link

Support for torch 2.2 #2560

Closed jakeBass closed 4 months ago

jakeBass commented 4 months ago

Pytorch 2.2 was released on January 30th. Currently, OpenNMT-py does not support torch 2.2.

Are there plans to support it? And what's the timeline for support?

If it's actually compatible and all that's needed is an update to setup.py, I would hope that it could be released quickly.

Thanks!

vince62s commented 4 months ago

the <2.2 is just a safeguard in case there are breaking changes but I don't see why it shouldn't work, maybe try it.

jakeBass commented 4 months ago

Is this a change you could make?

jakeBass commented 4 months ago

Hi @vince62s, I just wanted to check back on this. Can you or another maintainer make this change?

It'd be great to be able to use both torch 2.2 and OpenNMT-py off the shelf. Thanks!

vince62s commented 4 months ago

v3.5.0 released

jakeBass commented 4 months ago

Thank you!