search

OpenNTF / org.openntf.domino

Open replacement for lotus.domino package in HCL Domino
Apache License 2.0
66 stars 34 forks source link

package-only impl class declaration #104

Closed Fab1n closed 5 years ago

Fab1n commented 10 years ago

Nathan experimented with making some impl classes package-only (see: a58cc82).

In our development branch (of rPraml) we have a state where we set that back to public in Document.java and Database.java. We use concrete subclasses (in our own framwork built on top of ONTF) of the impl-files at the moment and need them to be public (currently only true for Document.java)

This should not diverge, so we should unify that. What's your opinion?

the-ntf commented 10 years ago

I have objection to moving them back to public. It was just an experiment. :-)

Sent from the desert of the real.

On Mar 4, 2014, at 6:32, Fab1n notifications@github.com wrote:

Nathan experimented with making some impl classes package-only (see: a58cc82).

In our development branch (of rPraml) we have a state where we set that back to public in Document.java and Database.java. We use concrete subclasses (in our own framwork built on top of ONTF) of the impl-files at the moment and need them to be public (currently only true for Document.java)

This should not diverge, so we should unify that. What's your opinion?

— Reply to this email directly or view it on GitHub.