search

OpenNTF / org.openntf.domino

Open replacement for lotus.domino package in HCL Domino
Apache License 2.0
65 stars 34 forks source link

Addition of Extension Point for EMBridge Subscriber Providers #160

Closed camac closed 5 years ago

camac commented 7 years ago

The extension point allows IEMBridgeSubscriberProviders to be registered that will provide a list of IEMBridgeSubscribers to be added during startup of the IEMBridgeMessageQueue

I've included a System.out.println("..") statement to output a message when a SubscriberProvider is being used. But let me know if you want to comment it out (I'm not sure on ODA Policy on use of console but I think this is handy to have to double check they are loading).

Also this code adds a plugin dependency on org.eclipse.core.runtime

Stwissel commented 7 years ago

How about logging the statement to a logger? Then you can decide at runtime what to show!

camac commented 7 years ago

I am using Serdar's XLogBack in my own plugins which is really great for this (and I like how it re-loads the logging config on the fly) I'm not sure what the ODA project recommends? I have seen a few System.out's around so I thought I would follow suit but I am happy to change it to something more suitable.

paulswithers commented 7 years ago

Logging is mea culpa without a doubt. We've got multiple loggers available in org.openntf.domino.logging - one to OpenLog, one to the console and one to a text file in IBM_TECHNICAL_SUPPORT. I was very new to logging in Java at the time!

the-ntf commented 7 years ago

If you see a System.out that's almost definitely my lazy ass. :)

On Tue, Mar 28, 2017 at 1:11 AM, Paul Withers notifications@github.com wrote:

Logging is mea culpa without a doubt. We've got multiple loggers available in org.openntf.domino.logging - one to OpenLog, one to the console and one to a text file in IBM_TECHNICAL_SUPPORT. I was very new to logging in Java at the time!

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OpenNTF/org.openntf.domino/pull/160#issuecomment-289683348, or mute the thread https://github.com/notifications/unsubscribe-auth/ACoex81act_o1nZL7SBaSDUsAr-R8uaIks5rqLKegaJpZM4MrE1D .

camac commented 7 years ago

haha many times I stare at the production console "Who the hell committed these System.out's? .... oh ... my bad"