search

OpenNTF / org.openntf.domino

Open replacement for lotus.domino package in HCL Domino
Apache License 2.0
65 stars 34 forks source link

Revisit DateTime's use of ICU Calendar #171

Closed jesse-gallagher closed 3 years ago

jesse-gallagher commented 4 years ago

The #toJavaCal and #setLocalTime methods we added to DateTime use com.ibm.icu.util.Calendar instead of java.util.Calendar:

https://github.com/OpenNTF/org.openntf.domino/blob/master/domino/core/src/main/java/org/openntf/domino/ext/DateTime.java#L125

Maybe there's a reason for this, but it's at the very least confusing to downstream users.

However, with the presence of java.time, it may be best to just deprecate these methods in favor of the existing #toGMTDateTime and a new method to set the time based on incoming java.time types.