PatrickKwinten
commented
1 year ago Hi, we reported a suppport case at HCL and according to their findings the OpenNTF code is not threadsafe. Here is a snippet of their report:
While review the logs its not HTTP task related issue however this issue with a multi-threaded application code and issue seems to happen in the openntf framework and custom code use. I have get reviewed this logs from extended support team and they checked in in JAVA core file and found the deadlock is detected and uses of the custom code in openntf framework Please find below the function in BOLD letters :
[Thursday 5:01 PM] Niels Groot 3XMTHREADINFO "Thread-10" J9VMThread:0x00000000008DD900, omrthread_t:0x00000198D63EA400, java/lang/Thread:0x00000000C0C1D510, state:B, prio=5 3XMJAVALTHREAD (java/lang/Thread getId:0x22, isDaemon:false) 3XMTHREADINFO1 (native thread ID:0x1884, native priority:0x5, native policy:UNKNOWN, vmstate:B, vm thread flags:0x00000281) 3XMCPUTIME CPU usage total: 2256.734375000 secs, user: 2182.031250000 secs, system: 74.703125000 secs, current category="Application" 3XMTHREADBLOCK Blocked on: org/openntf/domino/logging/LogFilterHandler@0x00000000C0C354A0 Owned by: "Thread-8" (J9VMThread:0x00000000008DC000, java/lang/Thread:0x00000000C0C1D3B0) 3XMHEAPALLOC Heap bytes allocated since last GC cycle=0 (0x0) 3XMTHREADINFO3 Java callstack: 4XESTACKTRACE at org/openntf/domino/logging/LogFilterHandler.publish(LogFilterHandler.java:299(Compiled Code)) 5XESTACKTRACE (entered lock: org/openntf/domino/logging/LogFilterHandler@0x00000000C0C354A0, entry count: 1) 4XESTACKTRACE at java/util/logging/Logger.log(Logger.java:738(Compiled Code)) 4XESTACKTRACE at java/util/logging/Logger.doLog(Logger.java:765(Compiled Code)) 4XESTACKTRACE at java/util/logging/Logger.log(Logger.java:788(Compiled Code)) 4XESTACKTRACE at java/util/logging/Logger.fine(Logger.java:1516(Compiled Code)) 4XESTACKTRACE at org/openntf/domino/impl/Base.getDelegate(Base.java:475(Compiled Code)) 4XESTACKTRACE at org/openntf/domino/impl/Session.getDatabase(Session.java:791(Compiled Code)) 5XESTACKTRACE (entered lock: java/lang/Object@0x00000000C0C1C688, entry count: 1) 4XESTACKTRACE at org/openntf/domino/impl/Session.getDatabase(Session.java:827(Compiled Code)) the "entered lock" reflect a java lock, one uses these for example to make an application thread safe LogFilterHandler.publish(LogFilterHandler.java:299 ---> that's opensource openntf Refer to : - https://github.com/OpenNTF/org.openntf.domino/blob/develop/domino/core/src/main/java/org/openntf/domino/logging/LogFilterHandler.java some info around synchronization in java: https://codegym.cc/groups/posts/377-top-50-job-interview-questions-and-answers-for-java-core-part-2 better (its just to a quick grasp on multi thread sync/locks that one needs when coding a multithreaded app) https://www.codejava.net/java-core/concurrency/java-synchronization-tutorial-part-1-the-problems-of-unsynchronized-code Java Synchronization Tutorial Part 1 - The Problems of Unsynchronized Code To know how synchronization works in Java, you need to understand what kinds of problem your application may face without synchronized code
jesse-gallagher
perlausten
here is an example of the error from log.nsf:
java.lang.NullPointerException 2023-05-26 09:44:29 HTTP JVM: at org.openntf.domino.impl.ViewEntryCollection.getCount(ViewEntryCollection.java:219) 2023-05-26 09:44:29 HTTP JVM: at org.openntf.domino.iterators.ViewEntryIterator.(ViewEntryIterator.java:57)
2023-05-26 09:44:29 HTTP JVM: at org.openntf.domino.impl.ViewEntryCollection.iterator(ViewEntryCollection.java:111)
2023-05-26 09:44:29 HTTP JVM: at org.acme.kkom.dao.AttachmentDominoDAO.updateAccess(AttachmentDominoDAO.java:510)
510 refers to the for loop statement (for (ViewEntry entry : entries) ) in:
View vw = db.getView(propDataSources.getProperty("vw_attach_unid")); if (null != vw){
ViewEntryCollection entries = vw.createViewEntryCollection(); if (null != key){ entries = vw.getAllEntriesByKey(key, true);
} else{ entries = vw.getAllEntries(); } //ODA way: for (ViewEntry entry : entries) { if(entry.isValid()){ if(entry.isDocument()){ Document doc = entry.getDocument();
if(null != item){ doc.copyItem(item); } else{ doc.removeItem(fieldName); }
if(doc.save(true,false)){ vw.refresh();
} } }
}
}