search

OpenNTF / p2-layout-provider

Java web app that serves as a basic proxy to provide a Maven repository front-end to p2 (Eclipse-style) repositories
Apache License 2.0
7 stars 5 forks source link

When using p2-layout-provider build output will show "[WARNING] Failed to retrieve plugin descriptor" #28

Closed gamerson closed 3 years ago

gamerson commented 3 years ago

Hello there, thanks so much for making p2-layout-provider, it was exactly what I was looking for!

When I run the build, I see this warning emitted. It seems to have no other side-effects, but I wanted to report it nonetheless.

[WARNING] Failed to retrieve plugin descriptor for org.openntf.maven:p2-layout-resolver:1.1.0: Failed to parse plugin descriptor for org.openntf.maven:p2-layout-resolver:1.1.0 (/Users/greg/.m2/repository/org/openntf/maven/p2-layout-resolver/1.1.0/p2-layout-resolver-1.1.0.jar): No plugin descriptor found at META-INF/maven/plugin.xml
jesse-gallagher commented 3 years ago

I've seen the same thing, but similarly dismissed it. All the same, I'd prefer to have no warnings, so I appreciate you making an issue for it - I'll investigate when I have a chance.

gamerson commented 3 years ago

Seems like maven-plugin-plugin would generate it with descriptor goal, however, that requires packing type maven-plugin. I don't know how you could use the descriptor goal to generate the plugin.xml.

On Wed, Nov 11, 2020 at 9:31 AM Jesse Gallagher notifications@github.com wrote:

I've seen the same thing, but similarly dismissed it. All the same, I'd prefer to have no warnings, so I appreciate you making an issue for it - I'll investigate when I have a chance.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/OpenNTF/p2-layout-provider/issues/28#issuecomment-725489361, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAERKFO5VGXDTR7HHBGBNR3SPKU47ANCNFSM4TSC2S2Q .

-- Greg Amerson Liferay Developer Tools Liferay, Inc. www.liferay.com

jesse-gallagher commented 3 years ago

@gamerson I'd originally avoided using the maven-plugin packaging because it halted the build due to lack of Mojos. However, it turns out I can just configure it to ignore that, and now it should be working. If you have a chance, could you try the 1.2.0-SNAPSHOT build currently up in OpenNTF's repo and see if it gets rid of the message on your end?

gamerson commented 3 years ago

I tested out 1.2.0-SNAPSHOT and it works well. Thanks!