Closed MahmoudMousaHamad closed 3 years ago
What was this comment on? I cannot find it on the PR
On Apr 7 2021, at 7:52 pm, Mahmoud Mousa Hamad @.***> wrote:
@MahmoudMousaHamad commented on this pull request. In src/social/BadgedAvatar.jsx (https://github.com/NextThought/nti.web.profiles/pull/47#discussion_r609170437): @@ -115,21 +97,19 @@ export default function BadgedAvatar({ entity, presence, expanded }) { position={Badge.POSITIONS.TOP_LEFT} {...Badge.offset(5, 4)} <BorderedAvatar entity={entity} presence={selected ? presence : ''} svg /> {({presence}) => { return ( <BorderedAvatar entity={entity} presence={selected ? presence.status : ''} Either I did something wrong trying this or this doesn't work as well as you think. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub (https://github.com/NextThought/nti.web.profiles/pull/47#discussion_r609170437), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAEM7LN3WFA3QAY5NDX6VMLTHT43LANCNFSM4ZVF6MEA).
@MahmoudMousaHamad commented on this pull request. In src/social/BadgedAvatar.jsx (https://github.com/NextThought/nti.web.profiles/pull/47#discussion_r609170437):
@@ -115,21 +97,19 @@ export default function BadgedAvatar({ entity, presence, expanded }) { position={Badge.POSITIONS.TOP_LEFT} {...Badge.offset(5, 4)} <BorderedAvatar entity={entity} presence={selected ? presence : ''} svg /> {({presence}) => { return ( <BorderedAvatar entity={entity} presence={selected ? presence.status : ''} Either I did something wrong trying this or this doesn't work as well as you think. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub (https://github.com/NextThought/nti.web.profiles/pull/47#discussion_r609170437), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AAEM7LN3WFA3QAY5NDX6VMLTHT43LANCNFSM4ZVF6MEA).
@@ -115,21 +97,19 @@ export default function BadgedAvatar({ entity, presence, expanded }) { position={Badge.POSITIONS.TOP_LEFT} {...Badge.offset(5, 4)}
There are failing tests.
It's still failing. see the red x next to your commit? chatbar fails as does store.
What was this comment on? I cannot find it on the PR
On Apr 7 2021, at 7:52 pm, Mahmoud Mousa Hamad @.***> wrote: