Fix compat with sphinx 2.0

OpenNTI / sphinxcontrib-programoutput

Sphinx extension for capturing program output

BSD 3-Clause "New" or "Revised" License

38 stars 18 forks source link

Fix compat with sphinx 2.0 #36

Closed keszybz closed 5 years ago

keszybz commented 5 years ago

C.f. https://github.com/pytest-dev/pytest/pull/4922/files.

jamadden commented 5 years ago

Can you please describe what problem this solves? We already support and test on Sphinx 2

keszybz commented 5 years ago

It was already deprecated in sphinx 1.6, and was removed at some point: https://github.com/sphinx-doc/sphinx/blob/6ef08a42df4534dbb2664d49dc10a16f6df2acb2/sphinx/application.py#L916. sphinxcontrib-programoutput was faling to build in Fedora rawhide: https://bugzilla.redhat.com/show_bug.cgi?id=1716531.

jamadden commented 5 years ago

Ah, I see now, it was just in our documentation configuration, not actually in the project's code. readthedocs builds with sphinx < 2, so it wasn't a problem there.

Thanks!