OpenNaja / cobra-tools

A suite of GUI tools for extracting and modifying OVL and OVS archives, as well as editing the associated in-house file formats. Also includes a model plugin for Blender. For downloads, guides, and FAQs visit:
https://opennaja.github.io/cobra-tools/
GNU General Public License v3.0
98 stars 28 forks source link

Creating an OVL or injecting an FGM in an ovl make the game crash. #291

Closed ilodev closed 1 year ago

ilodev commented 1 year ago

Describe the bug Creating an OVL or injecting an FGM in an ovl make the game crash.

To Reproduce Re-creating any of the game ovls with fgms in it should trigger the error. The game crashes when it loads the new ovls generated.

I can confirm that just loading the ovl makes the game crash even not using the fgm in it by any model. I changed a game prefab to include a new created ovl with one new fgm in it and the game crashed when spawned the asset.

Expected behavior not crashing, definitely :)

Version Info: all latest

Log Files: No errors in log files

Extra Files I'm attaching the generated OVL from my tests in case it helps

TestMats.zip

harlequinzeg0 commented 1 year ago

Fixed with commit 9ca1330, the issue was the implementation of the offsetstring. Unsure why it is broken but I have reverted to the previous method.

ilodev commented 1 year ago

Jesse, can you ask radrr to test it, he has a working case he can validate as fixed. Thanks for the revert tho, we’ll see how to redo the offset string change later on

On Sun, 18 Dec 2022 at 09:55, Jesse Ward @.***> wrote:

Fixed with commit 9ca1330 https://github.com/OpenNaja/cobra-tools/commit/9ca133028470eea45981083a7a5b09a5fef7f5b2, the issue was the implementation of the offsetstring. Unsure why it is broken but I have reverted to the previous method.

— Reply to this email directly, view it on GitHub https://github.com/OpenNaja/cobra-tools/issues/291#issuecomment-1356740879, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG42R7YHIJPPLODPISXJKKLWN3GPHANCNFSM6AAAAAATBJCDMI . You are receiving this because you authored the thread.Message ID: @.***>

RADRR1985 commented 1 year ago

thanks, I have tested and this problem is now fixed.

ilodev commented 1 year ago

You guys are the best!

On Sun, 18 Dec 2022 at 10:30, RADRR1985 @.***> wrote:

thanks, I have tested and this is problem is now fixed.

— Reply to this email directly, view it on GitHub https://github.com/OpenNaja/cobra-tools/issues/291#issuecomment-1356754936, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG42R7YVELOXD7U7HOGH4KTWN3KR5ANCNFSM6AAAAAATBJCDMI . You are receiving this because you authored the thread.Message ID: @.***>