OpenNaja / cobra-tools

A suite of GUI tools for extracting and modifying OVL and OVS archives, as well as editing the associated in-house file formats. Also includes a model plugin for Blender. For downloads, guides, and FAQs visit:
https://opennaja.github.io/cobra-tools/
GNU General Public License v3.0
98 stars 26 forks source link

Hitbox injection and creating new OVLs doesn't work #298

Closed RADRR1985 closed 1 year ago

RADRR1985 commented 1 year ago

Describe the bug Injection and creation new OVLs with 3 hitboxes (scenery.ms2 spatial.ms2 and navigation_.ms2) doesn't work in Jurassic World Evolution 2 after the Malta DLC update

To Reproduce Steps to reproduce the behavior:

Injection

  1. Extract files in \Jurassic World Evolution 2\Win64\ovldata\Content2\Buildings\Decorations\DEC_ConcreteBarrier\DEC_ConcreteBarrier.ovl
  2. Without doing any changes to scenery.ms2 spatial.ms2 and navigation_.ms2 inject them back into the OVL
  3. This will remove the existing scenery.ms2 spatial.ms2 and navigation_.ms2 in the ovl file and fail to inject these same ms2 files extracted before
  4. Error in the Log is attached

New OVL

  1. Extract files in \Jurassic World Evolution 2\Win64\ovldata\Content2\Buildings\Decorations\DEC_ConcreteBarrier\DEC_ConcreteBarrier.ovl
  2. Without doing any changes to scenery.ms2 spatial.ms2 and navigation_.ms2 Create a new OVL that includes all the files you extracted
  3. This will exclude the scenery.ms2 spatial.ms2 and navigation_.ms2 in the ovl file due to the error.
  4. Error in the Log is attached

Expected behavior Inject/create an ovl with scenery.ms2 spatial.ms2 and navigation_.ms2 files

Screenshots N/A

Version Info:

python 3.9.5 imageio 2.21.0 cobra-tools 2.5.0 stable version, 14f13c7 - Mon Dec 19 00:17:00 2022 +0100

Log Files:

ilodev commented 1 year ago

confirmed as fixed for me, tested in game. Great job Hendrix.

Note: can we demote the message to a warning? it is still treated as error

ilodev commented 1 year ago

There seems to still be a problem with this, reopening as requested by @RADRR1985

HENDRIX-ZT2 commented 1 year ago

Yup, the codegen should create pointers to store empty arrays still. That may cause trouble for our implementation of other formats, but it is the standard used by fdev.

HENDRIX-ZT2 commented 1 year ago

Is apparently fixed now, but may have messed with other formats. The behavior mimics fdevs tools now.