search

OpenNaja / cobra-tools

A suite of GUI tools for extracting and modifying OVL and OVS archives, as well as editing the associated in-house file formats. Also includes a model plugin for Blender. For downloads, guides, and FAQs visit:
https://opennaja.github.io/cobra-tools/
GNU General Public License v3.0
98 stars 26 forks source link

MS2 - PZ Wallsets crash when injected #311

Closed HENDRIX-ZT2 closed 1 year ago

HENDRIX-ZT2 commented 1 year ago

eg Content0\Environment\Scenery\Wallsets\MD_Mud_01

cause unknown, may be previously unknown pointer structures

more info here: https://discord.com/channels/680909673607463131/835566692041490452/1065803248470073344

HENDRIX-ZT2 commented 1 year ago

Still valid on vector-frag branch. It appears that only some ms2s crash.

HENDRIX-ZT2 commented 1 year ago

It seems to be largely random, though. Individual ms2s tend to work, when more are added at once, it tends to crash.

HENDRIX-ZT2 commented 1 year ago

Apparently, modelsmd_merge_shopfront_base and modelsmd_merge_shopfront have missing / different pointers after inject

HENDRIX-ZT2 commented 1 year ago

Investigate if the difference in pointers is due to not pushing nullptrs to the end of each pool

HENDRIX-ZT2 commented 1 year ago

Apparently a similar, possibly related issue on JWE2: https://discord.com/channels/680909673607463131/1092158344799715500

HENDRIX-ZT2 commented 1 year ago

Apparently fixed by removing the poorly implemented pool size condition.