OpenNaja / cobra-tools

A suite of GUI tools for extracting and modifying OVL and OVS archives, as well as editing the associated in-house file formats. Also includes a model plugin for Blender. For downloads, guides, and FAQs visit:
https://opennaja.github.io/cobra-tools/
GNU General Public License v3.0
98 stars 26 forks source link

JWE2 .ms2 import or export issue #319

Closed Kaiodenic closed 1 year ago

Kaiodenic commented 1 year ago

This seems a bit random and most of the files I tried worked perfectly fine. However, Walls.ovl (Jurassic World Evolution 2\Win64\ovldata\Content0\Buildings\SplineBased\Walls\Walls.ovl) breaks its models up between three files and some streams;

models1lod.ms2 and models2lods.ms2 seem to work fine and can be exported, edited, and imported again. models3lods.ms2 and its model2streams, however, causes an in-game crash if it is exported and then imported again. I tried this using both the current branch from about an hour ago (05/04/2023), as well as a build from around 08/03/2023. In today's build, the models can be exported and re-imported, and there doesn't appear to be any extra issues on top of that until the in-game crash.

The older build was more obvious because if you

Edit: On further testing, there is still an in-Cobra-Tools tell of the error. If you

Traceback (most recent call last): File "G:\JWE2 Modding\Cobra Tools 12\generated\formats\ovl__init.py", line 649, in add_files self.register_loader(loader) File "G:\JWE2 Modding\Cobra Tools 12\generated\formats\ovl\init__.py", line 663, in register_loader old_loader.remove() File "G:\JWE2 Modding\Cobra Tools 12\modules\formats\BaseFormat.py", line 257, in remove pool.offsets.remove(offset) KeyError: 14864

Hope this covers everything, and it's not just me doing something stupid! I haven't worked with .ms2 files in a while so I may be exporting/importing those files into the tools wrong. However, this is all done without any Blender editing.

HENDRIX-ZT2 commented 1 year ago

Probably related to #311. What happens without involving blender at all, ie. just injection?

Kaiodenic commented 1 year ago

That's right yeah, just standard unpacking/injection. My bad, I had a scan through the other bugs but didn't notice the PZ one!

HENDRIX-ZT2 commented 1 year ago

Apparently fixed by removing the poorly implemented pool size condition.