search

OpenNative / open-native

Open Native brings cross-platform communities together to help them collaborate and strengthen each other through development diversity.
https://open-native.org/
MIT License
454 stars 8 forks source link

feat: workspace updates #30

Closed NathanWalker closed 2 months ago

NathanWalker commented 3 months ago
NathanWalker commented 2 months ago

@ammarahm-ed I've pushed up some nice cleanups just now to get this in good shape. Fully works on iOS. Android has this remaining case if get a chance to check:

packages/core/react-android/bridge/src/main/java/com/bridge/Packages.java:38: error: TurboReactPackage is abstract; cannot be instantiated
      new TurboReactPackage(),
      ^

When trying this branch, best to:

// ensure using latest cli
npm install -g nativescript@latest

// ensure all deps are reset
yarn setup

// ensure demo hooks are regenerated
yarn demo:hooks

// now run android demo
yarn nx run demo:android
ammarahm-ed commented 2 months ago

@NathanWalker I will try to fix it today.

NathanWalker commented 2 months ago

@ammarahm-ed sorry for inconvenience realized tailwind.config was being gitignored, latest push fixes that.

ammarahm-ed commented 2 months ago

Hey @NathanWalker just fixed the issue on android. let me know if it's ready to merge. Both android & ios are building now.

NathanWalker commented 2 months ago

Awesome @ammarahm-ed i think this can become final 2.0 (no more alpha) 🎉