search

OpenNebula / one

The open source Cloud & Edge Computing Platform bringing real freedom to your Enterprise Cloud 🚀
http://opennebula.io
Apache License 2.0
1.23k stars 478 forks source link

one should use rbd snap to create a consistent image #872

Open OpenNebulaProject opened 6 years ago

OpenNebulaProject commented 6 years ago

Author Name: Fabian Zimmermann (Fabian Zimmermann) Original Redmine Issue: 3521, https://dev.opennebula.org/issues/3521 Original Date: 2015-01-22

Hello,

already suggested this at https://www.mail-archive.com/users@lists.opennebula.org/msg16746.html

I tested if "rbd copy" is creating a consistent (in time) copy of the source image.

What I did:

==> md5sum's differ

If I use a snapshot and copy the snapshot to the target-vol, the md5sums match.

I will create a merge-request

OpenNebulaProject commented 6 years ago

Original Redmine Comment Author Name: Fabian Zimmermann (Fabian Zimmermann) Original Date: 2015-01-22T15:58:42Z

https://github.com/OpenNebula/one/pull/45

OpenNebulaProject commented 6 years ago

Original Redmine Comment Author Name: Ruben S. Montero (@rsmontero) Original Date: 2015-01-22T16:48:24Z

Hi Fabian,

Thanks for this. On a second thought, OpenNebula does prevent this (i.e. an image in use (USED state) is not removed and so on...) So, did you have any corruption problems in the past? Maybe we have an issue at oned level that needs to be solve...

Cheers

OpenNebulaProject commented 6 years ago

Original Redmine Comment Author Name: Fabian Zimmermann (Fabian Zimmermann) Original Date: 2015-01-22T18:31:01Z

Hi,

Ruben S. Montero wrote:

Thanks for this. On a second thought, OpenNebula does prevent this (i.e. an image in use (USED state) is not removed and so on...) So, did you have any corruption problems in the past? Maybe we have an issue at oned level that needs to be solve...

I don't think there is a problem in oned, it should work like expected. I just worry about this single/special event if you create a "hot" hdd-snapshot while the vm is running.

I know the manual tells "you are responsible to avoid data corruption during snapshot-creation", but if ceph provides a clean (and simple!) way to reduce the risk, we should use it, isn't it?

Fabian

rsmontero commented 6 years ago

OpenNebula now uses rbs snapshot

vholer commented 5 years ago

Looks to me this is still valid issue. Problem is in making consistent disk "saveas". The proposed PR was to make a single-purpose snapshot just for the particular "saveas" operation, do a rbd copy from this snapshot and cleanup the snapshot aftert that.

Rescheduling this for 5.10.