OpenNebula / terraform-provider-opennebula

Terraform provider for OpenNebula
https://www.terraform.io/docs/providers/opennebula/
Mozilla Public License 2.0
63 stars 53 forks source link

Removing the optional gateway parameter does not clear it out from OpenNebula GUI. #428

Closed TGM closed 1 year ago

TGM commented 1 year ago

Provider version 1.1.1 OpenNebula version 6.4.0

If the gateway https://registry.terraform.io/providers/OpenNebula/opennebula/latest/docs/resources/virtual_network#gateway

was previously defined on resource creation and than removed the entry is not removed from the OpenNebula GUI.

However if the resource was previously defined and then set to an empty string, the value is updated.

Example previously defined:
resource "opennebula_virtual_network" "virtual_network" {
  cluster_ids     = <list of clusters>
  name            = "vlan100"
  bridge          = "br100"
  type            = "dummy"
  dns             = var.virtual_network_dns
  gateway         = x.x.x.x
  network_address = y.y.y.y
  network_mask    = z.z.z.z
}
Example of removal:
resource "opennebula_virtual_network" "virtual_network" {
  cluster_ids     = <list of clusters>
  name            = "vlan100"
  bridge          = "br100"
  type            = "dummy"
  dns             = var.virtual_network_dns
  network_address = y.y.y.y
  network_mask    = z.z.z.z
}
Example of replaced with string:
resource "opennebula_virtual_network" "virtual_network" {
  cluster_ids     = <list of clusters>
  name            = "vlan100"
  bridge          = "br100"
  type            = "dummy"
  dns             = var.virtual_network_dns
  gateway = " "
  network_address = y.y.y.y
  network_mask    = z.z.z.z
}

  # updated in-place
  ~ resource "opennebula_virtual_network" "virtual_network" {
      ~ gateway           = "10.0.0.1" -> " "
        id                = "1"
        name              = "vlan100"

Expected behavior: remove the entry from OpenNebula on deletion.

treywelsh commented 1 year ago

Seems like I didn't reworked the virtual network update code which had a problem with key deletion. Seems I shamefully missed it ...

For other resources like image and security groups the update code was reworked in PR #268