OpenNebula / terraform-provider-opennebula

Terraform provider for OpenNebula

https://www.terraform.io/docs/providers/opennebula/

Mozilla Public License 2.0

63 stars 53 forks source link

B-436: fix virtual network resource import #437

Closed treywelsh closed 1 year ago

treywelsh commented 1 year ago

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for PR followers and do not help prioritize the request

Description

Fix virtual network resource import, only checking the reservation_vnet is not enough: it doesn't take it's default value (-1) when we import

References

436

New or Affected Resource(s)

opennebula_virtual_network

Checklist

[ ] I have created an issue and I have mentioned it in References
[ ] My code follows the style guidelines of this project (use go fmt)
[ ] My changes generate no new warnings or errors
[ ] I have updated the unit tests and they pass succesfuly
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have updated the documentation (if needed)
[ ] I have updated the changelog file

treywelsh commented 1 year ago

Close for a deeper vnet refactoring in #428