F-414: add marketplace resource

treywelsh commented 1 year ago

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for PR followers and do not help prioritize the request

Description

Adds markeplace resource and datasource.

Remaining work:

addacceptance tests
update CHANGELOG
update goca dependency to integrate PR code merged (https://github.com/OpenNebula/one/pull/6312)

References

Close #414

New or Affected Resource(s)

opennebula_marketplace
data_opennenbula_marketplace

Checklist

[ ] I have created an issue and I have mentioned it in References
[ ] My code follows the style guidelines of this project (use go fmt)
[ ] My changes generate no new warnings or errors
[ ] I have updated the unit tests and they pass succesfuly
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have updated the documentation (if needed)
[ ] I have updated the changelog file

github-actions[bot] commented 1 year ago

This pull request is stale because it has been open for 30 days with no activity and it is not in a milestone. Remove 'status: stale' label or comment, or this will be closed in 5 days.

github-actions[bot] commented 1 year ago

This pull request is stale because it has been open for 30 days with no activity and it is not in a milestone. Remove 'status: stale' label or comment, or this will be closed in 5 days.

github-actions[bot] commented 1 year ago

This pull request is stale because it has been open for 30 days with no activity and it is not in a milestone. Remove 'status: stale' label or comment, or this will be closed in 5 days.

github-actions[bot] commented 1 year ago

This pull request is stale because it has been open for 30 days with no activity and it is not in a milestone. Remove 'status: stale' label or comment, or this will be closed in 5 days.

treywelsh commented 1 year ago

@frousselet @TGM I missed the capability to enable/disable a marketplace: https://docs.opennebula.io/6.6/integration_and_development/system_interfaces/api.html#one-market-enable

If you're ok I'll add a "disabled" boolean field soon This will first require a Goca PR to manage the marketplace state field

treywelsh commented 1 year ago

Depends on https://github.com/OpenNebula/one/pull/6312 to add state management. state list here

We need to add state management to be able to know if a marketplace is enabled or disabled

OpenNebula / terraform-provider-opennebula