TGM commented 1 year ago

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for PR followers and do not help prioritize the request

Description

Rename virtual machine resource attribute cpumodel to cpu_model

References

451

New or Affected Resource(s)

opennebula_virtual_machine

Checklist

[ ] I have created an issue and I have mentioned it in References
[ ] My code follows the style guidelines of this project (use go fmt)
[ ] My changes generate no new warnings or errors
[ ] I have updated the unit tests and they pass succesfuly
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have updated the documentation (if needed)
[ ] I have updated the changelog file

treywelsh commented 1 year ago

If we do this, we'll need to deprecate cpumodel, it would be nice to see if some others users are ok with this change or not, and then this PR should be completed with deprecations, documentation and changelog :)

If @frousselet is ok we could plan this in one of the future releases

frousselet commented 1 year ago

Ok for me.

@TGM, could you create an issue first please? I linked to #451, but it probably won't fix it. Also, the documentation needs to be updated.

github-actions[bot] commented 1 year ago

This pull request is stale because it has been open for 30 days with no activity and it is not in a milestone. Remove 'status: stale' label or comment, or this will be closed in 5 days.