only set randompasswd in graphics template if it's true

nilsding commented 3 months ago

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for PR followers and do not help prioritize the request

Description

older OpenNebula versions (like 5.12) interpret the RANDOM_PASSWORD as truthy if its value is not empty and therefore try to generate a password, which when using VNC will be too long and not truncated due to another bug that's already been fixed in the latest release.

(yes, I know, we should really update our setup ...)

References

New or Affected Resource(s)

opennebula_template

Checklist

[ ] I have created an issue and I have mentioned it in References
[x] My code follows the style guidelines of this project (use go fmt)
[x] My changes generate no new warnings or errors
[x] I have updated the unit tests and they pass succesfuly
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have updated the documentation (if needed)
[ ] I have updated the changelog file

frousselet commented 3 months ago

Hello @nilsding,

Unfortunately we don't support OpenNebula bellow 5.12. I would suggest you to fork the provider while you are on a version bellow 5.12 and compile your version including your changes on your side.

nilsding commented 3 months ago

Hi @frousselet, the readme mentions that OpenNebula ~> 5.12 is still supported 🤔

But the bug fixed by this PR also affects at least >= 6.0, < 6.1.80, as the random_password handling was changed around that time in https://github.com/OpenNebula/one/commit/0edcc7a7baa0d318671fa27731830e7d4775390d

frousselet commented 3 months ago

My bad, I misread 😬 I reopen it

github-actions[bot] commented 2 months ago

This pull request is stale because it has been open for 30 days with no activity and it is not in a milestone. Remove 'status: stale' label or comment, or this will be closed in 5 days.

akurz commented 3 weeks ago

Hi @frousselet, looks like this PR was "forgotten" - would you be so kind and reopen it, thx!

OpenNebula / terraform-provider-opennebula