Open ccascone opened 4 years ago
Submitted #105 to wrap output text in terminal message. @zdw can you please try it and deploy on Gerrit?
Looks good, one minor naming convention note.
Tested on ONOS gerrit, works! Thanks @ccascone!
It doesn't seem to work as expected. What I get is:
remote: Hi user, this is the ONF bot 🤖 I'm glad you want to contribute to our
remote: projects! However, before accepting your contribution, we need to ask
remote: you to sign a Contributor License Agreement (CLA). You can do it online,
remote: it will take only few minutes: ✒️ 👉 https://cla.opennetworking.org
remote: After signing, make sure to add your email carmelo@opennetworking.org to
remote: the agreement.
The URL with the pen emoji should be on an independent line
Seems like the rewrap algorithm is:
The current output isn't unusable, but you're right that it could be improved.
This is ugly
Message lines should be split such that the total line lenght including
remote :
is no more than 80 characters. For example: