search

OpenNetworkingFoundation / cla-manager

Automated CLA management and verification for ONF projects on Github and Gerrit
https://cla.opennetworking.org
3 stars 6 forks source link

An Identity can be instantiated without a Name field, check if it's set before trimming whitespaces #218

Closed teone closed 3 years ago

teone commented 3 years ago

Describe the PR

This is causing the identities not to show up in the UI. The stored data are fine. Needs merge ASAP.

codecov[bot] commented 3 years ago

Codecov Report

Merging #218 (90bd50a) into master (2f0def8) will decrease coverage by 0.11%. The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #218      +/-   ##
==========================================
- Coverage   83.39%   83.27%   -0.12%     
==========================================
  Files          13       13              
  Lines         572      574       +2     
  Branches       65       67       +2     
==========================================
+ Hits          477      478       +1     
- Misses         95       96       +1
Impacted Files Coverage Δ
common/model/identity.js 96.66% <66.66%> (-3.34%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2f0def8...90bd50a. Read the comment docs.