search

OpenNetworkingFoundation / cla-manager

Automated CLA management and verification for ONF projects on Github and Gerrit
https://cla.opennetworking.org
3 stars 6 forks source link

Change the API to handle the pagination when listing Github teams #237

Closed hwchiu closed 3 years ago

hwchiu commented 3 years ago

Describe the PR APIoctokit.teams.list returns at most 30 teams in its response but we have 41 teams so we have to call the function multiple times to collect full list.

Use the builtin function octokit.paginate to iterate all responses.

Fixes #236

codecov[bot] commented 3 years ago

Codecov Report

Merging #237 (79972ec) into master (0211f88) will decrease coverage by 0.29%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
- Coverage   83.56%   83.27%   -0.30%     
==========================================
  Files          13       13              
  Lines         572      574       +2     
  Branches       67       67              
==========================================
  Hits          478      478              
- Misses         94       96       +2
Impacted Files Coverage Δ
functions/lib/github.js 57.89% <0.00%> (-0.78%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0211f88...79972ec. Read the comment docs.