search

OpenNeuroLab / brainspell-neo

Working on a new version of Brainspell (an open-source platform for neuroimaging literature) to make a public JSON API that collaborators can contribute to, switch out the stack for better scalability, and provide statistical features to better conduct meta-analyses.
MIT License
15 stars 6 forks source link

Websocket functionality #72

Closed Sharabesh closed 5 years ago

Sharabesh commented 5 years ago

Summary Long running computations especially for the forcePullFromGithub endpoints were timing out due to Heroku router limitations. Heroku prevents any single request from taking over 30 seconds if there are no updates posted to the client in that time. To get around this fact we are sending periodic messages to the client indicating the loading status of their query.

Some method calls to handle_github_request were also encountering issues due to the way API_endpoint calls were structures so we switched to a different calling convention.

Test plan Tested on the forcePullCollections endpoint and validated that new data was transferred from github.

neelsomani commented 5 years ago

I think we should go ahead and merge it

Sharabesh commented 5 years ago

Since it looked ok I'm going to go ahead and merge it.