OpenNeuroOrg / openneuro

A free and open platform for analyzing and sharing neuroimaging data
https://openneuro.org/
MIT License
112 stars 40 forks source link

.bidsignore abuses #2419

Open effigies opened 2 years ago

effigies commented 2 years ago

This issue is intended to track datasets that are abusing .bidsignore. If we can find classes of abuse, we can propose new validator rules.

The fixes won't be here, but this seems like more of an ON issue than a validator issue.

xref #1199 https://github.com/bids-standard/bids-validator/issues/844 https://github.com/bids-standard/bids-validator/issues/1103

Remi-Gau commented 2 years ago

ds002247 and ds002602 : The Reading Brain Project L1 and L2

https://openneuro.org/datasets/ds002247/versions/1.0.0 https://openneuro.org/datasets/ds002602/versions/1.0.1

Not a valid BIDS dataset despite this bidsignore content

/L2_Adults_LHQ.tsv
text_data_p2.xlsx
/L2_Adults_demographics.tsv
/L2_Adult_Eyetracking.xlsx
/Materials.txt
/rest_instructions.json
/task_instructions.json
*_physio.tsv
L2_Adults_RBQ.tsv
Reading_Brain_Methods_L1Adults.pdf
TW1.json
/sub-*/fmap/sub-*_acq-multiband_dir-PA_dwi.nii.gz
nellh commented 11 months ago

From discussion today, we'd like to track the ratio of ignored files and the bytes ignored. This will be provided in the summary for the bids-validator output and OpenNeuro will raise the warning to error.