OpenNeuroOrg / openneuro

A free and open platform for analyzing and sharing neuroimaging data
https://openneuro.org/
MIT License
113 stars 40 forks source link

`InternalError: too much recursion` for ds004504 #2999

Open effigies opened 7 months ago

effigies commented 7 months ago

What went wrong?

Reported by user: ds004504 is inaccessible. Going to https://openneuro.org/datasets/ds004504 results in an "InternalError: too much recursion" error.

Expected behavior

Show dataset.

How to reproduce

Desktop

Phone

Additional information

image

image

rwblair commented 7 months ago

I'm leaning towards the something in the dataset_description.json not playing well with the markdown to jsx library: https://github.com/quantizor/markdown-to-jsx/issues/496 https://github.com/quantizor/markdown-to-jsx/issues/473

rwblair commented 7 months ago

Re that second link, ds004504 README has a lot of consecutive spaces in it.

effigies commented 7 months ago

Alternatives identified in those threads:

effigies commented 7 months ago

Opened #3000 to do the minimal fix. Not sure if it would be better to switch to another library that doesn't implement a CFL with regular expressions.

nellh commented 7 months ago

I implemented the switch to react-markdown in #3009. This is closer to the GitHub markdown feature set anyways that we are aiming for.