OpenNeuroOrg / openneuro

A free and open platform for analyzing and sharing neuroimaging data
https://openneuro.org/
MIT License
106 stars 38 forks source link

Embed schema.org JSON-LD in dataset landing pages #352

Closed chrisgorgo closed 5 years ago

chrisgorgo commented 6 years ago

As described in point 7 of https://www.biorxiv.org/content/early/2017/10/09/097196.full.pdf+html. The @id field should be set to doi URL when #333 will be implemented (however work on schema.org can start earlier).

When deployed pleas comment on https://github.com/datacite/freya/issues/8

olgn commented 6 years ago

@chrisfilo point 7 of this paper lists a couple of options for the fields contained in the json-ld data schema - are there any metadata that you would like to see included which are not present in the following schema?

<script type="application/ld+json">
 {
 "@context": "http://schema.org",
 "@type": "Dataset",
 "@id": "https://doi.org/10.2210/pdb5m95/pdb",
 "name": "STAPHYLOCOCCUS CAPITIS DIVALENT METAL ION TRANSPORTER (DMT) IN
 COMPLEX WITH MANGANESE",
 "author": [
 {
 "@type": "Person",
 "givenName": " I.A.",
 "familyName": "Ehrnstorfer"
 },
 {
 "@type": "Person",
 "givenName": " E.R.",
 "familyName": " Geertsma"
 },
 {
 "@type": "Person",
 "givenName": " E.",
 "familyName": " Pardon"
 },
 {
 "@type": "Person",
 "givenName": " J.",
 "familyName": " Steyaert"
 },
 {
 "@type": "Person",
 "givenName": " R.",
 "familyName": " Dutzler"
 }
 ],
 "datePublished": "2016-11-30",
 "publisher": "Protein Data Bank, Rutgers University",
 "citation": [
 {
 "@type": "ScholarlyArticle",
 "@id": "https://doi.org/10.1038/nsmb.2904"
 }
 ]
 }
</script>
olgn commented 6 years ago

eg @id, name, author(s), publisher, datePublished, citation(s)?

olgn commented 6 years ago

full list is here

chrisgorgo commented 6 years ago

"license" (CC0) would be nice to add. "description" and "version" should be easy to populate.

olgn commented 6 years ago

would 'version' be the snapshot version? and do you imagine 'description' getting populated from the readme file?

chrisgorgo commented 6 years ago

Yes and yes :)

Best, Chris

PS Apologies for brevity and potential typos. This message was composed on a phone.

On Wed, Mar 7, 2018, 4:29 PM Teal Hobson-Lowther notifications@github.com wrote:

would 'version' be the snapshot version? and do you imagine 'description' getting populated from the readme file?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenNeuroOrg/openneuro/issues/352#issuecomment-371334963, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOkpxtm1ziQLDk7kU6_bR6xn4un2AQZks5tcHt-gaJpZM4Rl_n3 .

chrisgorgo commented 5 years ago

This functionality seems to have regressed. See https://search.google.com/structured-data/testing-tool#url=https%3A%2F%2Fopenneuro.org%2Fdatasets%2Fds001421%2Fversions%2F00001

nellh commented 5 years ago

It looks fine to me, did it work with the Google testing tool before? Googlebot can read this but I don't see how the testing tool would.

<script type="application/ld+json">
{
  "@context": "http://schema.org",
  "@type": "Dataset",
  "name": "[11C]SB207145 PET Cimbi database example",
  "author": [
    {
      "@type": "Person",
      "givenName": "Melanie",
      "familyName": "Ganz-Benjaminsen"
    },
    {
      "@type": "Person",
      "givenName": "Martin",
      "familyName": "Noergaard"
    }
  ],
  "datePublished": "2018-07-09T18:49:22.052Z",
  "dateModified": "2018-07-19T00:53:51.972Z",
  "license": "NA - not for public distribution (yet)",
  "publisher": "OpenNeuro",
  "description": "This dataset consists of test and retest measurements from one individual using [11C]SB207145 to measure 5-HT4R availability. There is no arterial measurement for this tracer.  Cerebellum is the most appropriate reference region.",
  "version": "00001"
}
</script>
chrisgorgo commented 5 years ago

Yeah - the testing tool used to work (but it could've changed). How are you seeing what google bot is getting?

I'm trying fetch as googlebot (https://www.google.com/webmasters/tools/googlebot-fetch-details?hl=en&authuser=0&siteUrl=https://openneuro.org/&path=datasets/ds001421/versions/00001&timestamp=1)

image

nellh commented 5 years ago

We need to fix a crash in Chrome 41 so that Googlebot can load most pages again to fix this.