OpenNews / opennews-source

Code refactor for Source, a website that spotlights work from the developers, designers, and data analysts at the intersection of journalism and tech: https://source.opennews.org
MIT License
5 stars 3 forks source link

The ongoing content audit #102

Closed kissane closed 7 years ago

kissane commented 7 years ago

We should check in on this later this afternoon, @tsl-lindsay, to do status updates, see if we're in peril of not hitting launch goals/generally sanity-check everything. Once we hit launch-state, we can pull out the remaining goals for a post-launch push.

kissane commented 7 years ago

Making a note to remember that this includes recent repos—need to check for working repo embeds, logos, etc.

kissane commented 7 years ago

@tsl-lindsay and I talked this through, and we're doing pretty well. https://github.com/OpenNews/opennews-source/issues/109 is the exception, so I've waved for help there.

kissane commented 7 years ago

@tsl-lindsay, might you have Simon Elvery's XKCD-style narrative charts images? I can't find them anywhere. :/

kissane commented 7 years ago

Same with Jennifer Stark's uber article: https://opennews-source-staging.herokuapp.com/articles/how-i-investigated-uber-surge-pricing-dc/

kissane commented 7 years ago

Same with Eva's: https://opennews-source-staging.herokuapp.com/articles/data-journalism-should-thrive-cross-border-collabo/

tsl-lindsay commented 7 years ago

Looking for the others, this is Tiff's - https://opennews-source-staging.herokuapp.com/articles/unlearning/

https://unsplash.com/@sylwiabartyzel?photo=L4NfLl7SJGU

tsl-lindsay commented 7 years ago

Okie! I have all of these. I'll restore 'em right now.

kissane commented 7 years ago

We're gonna have to go back to Matt for these, as Kio's stash doesn't have 'em and I didn't produce it. https://opennews-source-staging.herokuapp.com/articles/true-facts-maybe/

kissane commented 7 years ago

Noting here that this is mostly fixed but kind of a hairball: https://opennews-source-staging.herokuapp.com/articles/when-and-how-use-census-microdata/

kissane commented 7 years ago

All the GIFs in Lena's loops article have died, presumably because of their weird Javascript. Which, tbh, I can kill if that's the best thing. Just noting it here. https://opennews-source-staging.herokuapp.com/articles/power-loops/

kissane commented 7 years ago

Hmmmm. @tsl-lindsay, could you have produced this one, or is it before your time? https://opennews-source-staging.herokuapp.com/articles/tracking-amtrak-188/

kissane commented 7 years ago

And we'll have to go back to Eva for this one: https://opennews-source-staging.herokuapp.com/articles/developing-data-journalists-developing-world/

tsl-lindsay commented 7 years ago

I think I had just started then. Let me investigate!

On Wed, Feb 8, 2017 at 4:37 PM, Erin Kissane notifications@github.com wrote:

Hmmmm. @tsl-lindsay https://github.com/tsl-lindsay, could you have produced this one, or is it before your time? https://opennews-source- staging.herokuapp.com/articles/tracking-amtrak-188/

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenNews/opennews-source/issues/102#issuecomment-278485095, or mute the thread https://github.com/notifications/unsubscribe-auth/AE7jQkWcHnY60BUq6-SAIy7dOTQuP38Iks5rakOZgaJpZM4L5-9v .

tsl-lindsay commented 7 years ago

@kissane For the Amtrak story, I have one of the graphics in their original draft doc but not the cover image (which looks like it was a screenshot.)

I didn't produce that one: do you have any memory of what the screenshot would have been?

I think we can safely pull a new one if no.

kissane commented 7 years ago

I have nooooo idea, alas, but I fully advocate faking it

kissane commented 7 years ago

Or just clearing the image, it's fine—no need to spend time reconstructing. (There's a checkbox for clearing cover images)

tsl-lindsay commented 7 years ago

I'll just add a new screenshot, v simple, thx!

kissane commented 7 years ago

wooo

kissane commented 7 years ago

I have begun murdering the troublesome images. Ruthlessly.

kissane commented 7 years ago

Another for you, @tsl-lindsay, if you can remember: https://opennews-source-staging.herokuapp.com/articles/story-changes-based-readers-birth-year-how-we-made/

tsl-lindsay commented 7 years ago

OOoo I bet I can do the cover but may need to murder the animation

kissane commented 7 years ago

murder it 🔪

tsl-lindsay commented 7 years ago

done, and miraculously I HAD THE ANIMATION so a GIF soul got more time on this planet today.

kissane commented 7 years ago

good fairy lindsay

ryanpitts commented 7 years ago

@kissane I was worried about the Lena gifs article. The javascript on the new site loads faster and cleaner than it ever did before, but it also is more complicated to add special per-article js now. When there's time, I'd like to talk to Ethan about how best to approach. Not sure what this means for Lena's story rn though.

kissane commented 7 years ago

OK, all the articles missing cover images in the top 250 list + recent lists either have their covers restored or have been flagged for follow-up with authors after we exhausted our local images. (The ones we're following up on are all missing more than the covers—things that were just missing a cover that we couldn't find now just have no covers, in most cases, but there aren't very many of those.)

There's a list of about 20 articles left that have covers but have broken inline images that I will fix or flag after dinner, but we are very very close to the launch goal for the articles.

After that, there are some repos and orgs to do, and a few more People photos. @tsl-lindsay, if you're working this evening for a bit, which is totally not required, may I give you some logos to hunt down? We need the orgs mentioned in the last 20 articles, I think.

tsl-lindsay commented 7 years ago

These last 20 are done!

tsl-lindsay commented 7 years ago

So @kissane - the logos are displaying in a somewhat crunched-up fashion. Feels on this? This is on the community page. https://opennews-source-staging.herokuapp.com/community/

screen shot 2017-02-08 at 6 25 32 pm

tsl-lindsay commented 7 years ago

Meantime, I'm gonna just try to make them all the width of the Vox one

ryanpitts commented 7 years ago

All promo slots in the new design crop to a 3:2 aspect ratio (at full browser width, they're 300x200). One way to approach this, at least, would be to upload image files with built-in whitespace around the logo that gives it that aspect ratio.

tsl-lindsay commented 7 years ago

Ooo, genius, thanks @ryanpitts

kissane commented 7 years ago

Thanks, @tsl-lindsay!

Also I have another image-finding request for you for whenever, no hurry. https://opennews-source-staging.herokuapp.com/articles/how-we-made-3d-model-pulse-nightclub/

tsl-lindsay commented 7 years ago

Excellent - working on that one now

kissane commented 7 years ago

On mooooore waah https://opennews-source-staging.herokuapp.com/articles/digital-self-defense-journalists-introduction/

kissane commented 7 years ago

Also https://opennews-source-staging.herokuapp.com/articles/virtual-reality-rest-us/

kissane commented 7 years ago

And here we have a YouTube embed that's MIA (in Safari as well as Chrome) — @ryanpitts, should I be doing something different to get those to appear for us? https://opennews-source-staging.herokuapp.com/articles/slouching-toward-sensor-journalism/

ryanpitts commented 7 years ago

@kissane looks like all you need to do is change the iframe src attribute to an https link rather than http. I think the browser is blocking this because we're serving https, not anything to do with site code.

tsl-lindsay commented 7 years ago

Those three are done @kissane - just fixing image paths. I can check for this in more articles where the article images are MIA, unless you have tabz open.

On Wed, Feb 8, 2017 at 7:21 PM, Ryan Pitts notifications@github.com wrote:

@kissane https://github.com/kissane looks like all you need to do is change the iframe src attribute to an https link rather than http. I think the browser is blocking this because we're serving https, not anything to do with site code.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenNews/opennews-source/issues/102#issuecomment-278517451, or mute the thread https://github.com/notifications/unsubscribe-auth/AE7jQq1KPDfcZenVJGxGjDsbEg4fOdXhks5ramoJgaJpZM4L5-9v .

kissane commented 7 years ago

@ryanpitts Eeeeeasy ok awesome thanks!

kissane commented 7 years ago

@tsl-lindsay I have four million tabs open, but wait—were those images actually on the server after all? I didn't have local copies, so I passed them to you, urk, sorry. (How were the paths malformed?)

ryanpitts commented 7 years ago

I'm making a quick pass and updating other http youtube links

kissane commented 7 years ago

Any idea if you have these, @tsl-lindsay? https://opennews-source-staging.herokuapp.com/articles/better-docs/

tsl-lindsay commented 7 years ago

The path was pointing to a media folder and was a relative path.. if I find another one I will copy it in. No prob!

I do have those, for Better Docs!

On Wed, Feb 8, 2017 at 7:38 PM, Erin Kissane notifications@github.com wrote:

Any idea if you have these, @tsl-lindsay https://github.com/tsl-lindsay? https://opennews-source-staging.herokuapp.com/articles/better-docs/

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OpenNews/opennews-source/issues/102#issuecomment-278520422, or mute the thread https://github.com/notifications/unsubscribe-auth/AE7jQkAR2GGWyxKLiVQ5xiNQW2CGu380ks5ram4DgaJpZM4L5-9v .

kissane commented 7 years ago

And all our featured repos now have images.

kissane commented 7 years ago

And we now have photos for pretttty much everyone who will be a featured Person.

kissane commented 7 years ago

I AM CLOSING THIS