OpenNews / opennews-source

Code refactor for Source, a website that spotlights work from the developers, designers, and data analysts at the intersection of journalism and tech: https://source.opennews.org
MIT License
5 stars 3 forks source link

question about code_detail page #114

Closed ryanpitts closed 7 years ago

ryanpitts commented 7 years ago

was looking at a couple of the code pages and started wondering if the link to the actual repo was minimized more than we want. In most cases, it's at left under the summary description, as in

screen shot 2017-02-08 at 9 17 32 am

But when we don't have "demo site" or "last pushed" data for a repo, that link floats over the to right and kind of disappears, as in

screen shot 2017-02-08 at 9 18 14 am

Feels like it'll be a very common use case for people to want to jump from these pages to the GitHub repo, and I found myself searching for that link even though I knew where it was supposed to be.

So a couple thoughts:

1) @beep it looks like this is following this rule:

    .repo-meta li:last-child {
        flex: 1;
        text-align: right;
        margin-right: 0;
    }

And editing to this will pull solo links back over to the left:

    .repo-meta li:last-child {
        flex: 1;
        text-align: right;
        margin-right: 0;
    }
    .repo-meta li:first-child {
        text-align: left;
    }

Any unforeseen consequences I'm missing?

2) @beep @kissane here's an and/or option along with the above, is is adding a "see the repo" link to the summary graf too ... duplicative?

screen shot 2017-02-08 at 9 33 57 am

kissane commented 7 years ago

here's an and/or option along with the above, is is adding a "see the repo" link to the summary graf too ... duplicative?

I am totally fine with this, we do similar things many other places.

beep commented 7 years ago

@ryanpitts hi sorry i’ve been in meetings all morning, just getting re-situated now. more soon!

beep commented 7 years ago

Any unforeseen consequences I'm missing?

@ryanpitts Nope, that looks fine!

here's an and/or option along with the above, is is adding a "see the repo" link to the summary graf too ... duplicative?

I think that looks stellar. (Perhaps “Visit the repo” for non-sighted visitors?)

ryanpitts commented 7 years ago

awesome, will push both these changes

ryanpitts commented 7 years ago

closed with https://github.com/OpenNews/opennews-source/commit/d18d81f503d14faceebc9476b3498b19de279ba2