search

OpenNews / opennews-source

Code refactor for Source, a website that spotlights work from the developers, designers, and data analysts at the intersection of journalism and tech: https://source.opennews.org
MIT License
5 stars 3 forks source link

Guides bug, I think #138

Closed kissane closed 7 years ago

kissane commented 7 years ago

When I try to preview this guide https://source.opennews.org/admin/guides/guide/7/change/

I get a 404 at https://source.opennews.org/guides/source-guide-census-reporting/

…and this is true whether or not the View on Site box is checked. Other guides are working as expected. Hrrrrrm.

ryanpitts commented 7 years ago

hmm, yep, I just got a 500 alert on that URL as well. Will investigate.

kissane commented 7 years ago

500, indeed!

ryanpitts commented 7 years ago

oh whoops, this is happening because I wasn't testing for the existence of guide.image in the Facebook/Twitter OG tags in the head, and the thumbnailer doesn't fail silently in this case.

kissane commented 7 years ago

ahhhhhh that makes sense

ryanpitts commented 7 years ago

pushing a fix to staging

ryanpitts commented 7 years ago

ok, we're all good in production! https://source.opennews.org/guides/source-guide-census-reporting/

closing this ticket in https://github.com/OpenNews/opennews-source/commit/1a4414f941b88277fb30ba9a3c6ba3e735372c78

kissane commented 7 years ago

YAY THANKS