Articles are missing their tags

[kissane]

Not sure why it took me until today to remember this, but it looks like most articles since we redesigned aren't displaying their tags in the left margin, but older articles (https://source.opennews.org/articles/what-i-learned-researching-newsroom-and/) are. @ryanpitts, any sense of where they mighta got to?

[tsl-lindsay]

Oh gosh! I noticed this too and kept forgetting to mention it.

On Thu, Mar 30, 2017 at 2:47 PM, Erin Kissane notifications@github.com wrote:

Not sure why it took me until today to remember this, but it looks like most articles since we redesigned aren't displaying their tags in the left margin, but older articles (https://source.opennews.org/ articles/what-i-learned-researching-newsroom-and/) are. @ryanpitts https://github.com/ryanpitts, any sense of where they mighta got to?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OpenNews/opennews-source/issues/140, or mute the thread https://github.com/notifications/unsubscribe-auth/AE7jQsHZUW1ZjKH3jMQqC4cL3pNaMHOYks5rrAbRgaJpZM4Mu1eK .

[kissane]

Yeah, same, my brain triaged it down without permission.

[ryanpitts]

ugh, so this goes back to the fateful decision where we split "concept" and "tech" tags into two separate fields, for which I will always bear a small amount of ill will toward slifty. Not enough ill will to be like actual malice or anything, but just enough to regularly remind him that his hoodie sleeves are different lengths.

There's supposed to be an automatic task on article save that compiles those two tag lists into a single list for display, dumps it into an uneditable "Tags" field, and that is what the template draws from. But it looks like that task isn't firing.

I'll have to investigate why.

[kissane]

I am so sorry and also I feel this is a perfectly precision-calibrated level of ill will toward slifty, both for this and in general.

[kissane]

tiny bump for after srccon session sorting

[ryanpitts]

appreciate the reminder -- putting this on the list for first half of the week

[ryanpitts]

this is fixed in https://github.com/OpenNews/opennews-source/commit/8457d7577f680f703282d0cea68bef2a7ab93844 and pushed to staging, ready for production on Monday

[ryanpitts]

fwiw, this bug popped up because of recent updates to Django, which no longer does anything with the value of readonly fields in the admin. Which is a sensible way of doing things for sure, just meant I needed to do things a bit differently to compile that merged tags field.

[ryanpitts]

(btw this works when you save an article, so will just require a quick tour through recent articles hitting "save." I'll do this after we push to production.)

[kissane]

I can help!

[ryanpitts]

all done