Template integration: feedback on code_detail template

[ryanpitts]

Hello hello initial integration done on the repo pages.

For example, here's one, or you can hit anything from the code list page.

[beep]

@ryanpitts you are a machine. This is so exciting to see!

From a process standpoint, do you have a preference if I file issues on code detail pages here, or in separate issues?

[ryanpitts]

It feels like it could be helpful to keep things corralled into feedback threads for each template, if only for being able to mentally check off "this is done" for each one. BUT, it's far more important to go with a workflow that you find productive, and if that's separate issues that's fine with me too.

[beep]

@ryanpitts Keeping stuff corralled sounds perfect to me. Thanks!

[beep]

Line wrapping! My old nemesis.

Noticed this on the detail page, but this affects all .list-promos blocks, too:

Namely, the tops of the tags are uneven across the row.

I could try to mitigate this a bit by enforcing a minimum height on the headlines:

Alternately, I could explore other treatments of the content in this module. (Maybe the titles could be pulled into the image somehow? IDK)

This isn’t a bug per se, but I did feel compelled to log it.

[ryanpitts]

I don't mind the mitigated min-height version, and the odd case where it's a three-line title there just doesn't feel like a huge problem to me. I wonder if it looks awkward when all three promos have short titles, though. Will it feel like a weird gap? Probably not?

[kissane]

I'm actually fine with both versions—tags starting at uneven heights and the bumped-down version. They both look clear/legible to my eyes, so I'll leave the decision to youse.

Otherwise, everything is looking just glorious.

[ryanpitts]

yeah, honestly I don't mind the uneven heights version either.

[beep]

@ryanpitts @kissane Okay, cool! Let’s leave them as-is, then. (But if your opinions change, do let a @beep know.)

[ryanpitts]

@beep hmm, the repo.js bit seems to be failing. Not sure if anything changed in the js, or if I have something misconfigured in the template: https://opennews-source-staging.herokuapp.com/code/narrative-charts/

[beep]

@ryanpitts Hm! It seems okay here:

Are you still seeing the error? If so, mind hooking me up with a little more info? (Any console information would be very helpful, as would the browser you’re using.)

Thanks!

[ryanpitts]

oh hey. Yep, working here now, I wonder if my browser had just cached old js. Seems all good now!

[beep]

phew yay